Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument the CSI Server with OTel Traces #3465

Closed
wants to merge 5 commits into from
Closed

Conversation

gkrenn
Copy link
Contributor

@gkrenn gkrenn commented Jul 15, 2024

Description

Adds OTel instrumentation to the csidriver containers and links them to the webhook created span.
In addition, the singletons were replaced with init functions.

Jira

How can this be tested?

  • Apply the otel secret as described in doc/otel.md.
  • Apply a dynakube with cloud native and create some pods.
  • Check the otel traces in your tenant.

@gkrenn gkrenn requested a review from a team as a code owner July 15, 2024 14:09
@gkrenn gkrenn changed the title Feature/csi otel Instrument the CSI Server with OTel Traces Jul 15, 2024
@gkrenn gkrenn added core Changes to core functionality of the Operator troubleshoot Changes related to logic meant for helping the user to troubleshoot and removed troubleshoot Changes related to logic meant for helping the user to troubleshoot labels Jul 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 48.85057% with 89 lines in your changes missing coverage. Please review.

Project coverage is 57.20%. Comparing base (b6b9122) to head (48859a8).

Files Patch % Lines
pkg/controllers/csi/driver/server.go 0.00% 48 Missing ⚠️
...g/controllers/csi/driver/volumes/host/publisher.go 19.04% 17 Missing ⚠️
...kg/controllers/csi/driver/volumes/app/publisher.go 37.50% 10 Missing ⚠️
pkg/util/dtotel/controller_runtime/writer.go 0.00% 5 Missing ⚠️
pkg/util/dtotel/traces.go 33.33% 4 Missing ⚠️
pkg/webhook/mutation/pod/register.go 0.00% 3 Missing ⚠️
pkg/util/dtotel/controller_runtime/reader.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3465      +/-   ##
==========================================
- Coverage   57.28%   57.20%   -0.09%     
==========================================
  Files         344      344              
  Lines       19796    19836      +40     
==========================================
+ Hits        11340    11347       +7     
- Misses       7216     7250      +34     
+ Partials     1240     1239       -1     
Flag Coverage Δ
unittests 57.20% <48.85%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gkrenn gkrenn closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to core functionality of the Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants