Adds ruxitagentproc.conf update mechanism for CSI driver #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0sewa0
requested review from
chrismuellner,
meik99,
luhi-DT,
gkrenn,
waodim,
baichinger and
DTMad
chrismuellner
requested changes
Nov 18, 2021
baichinger
reviewed
Nov 19, 2021
There was a problem hiding this comment.
Please pay attention to consistent naming. Different terms are used throughout the code: Ruxit, RuxitConf, and RuxitProc. We agreed to call the API endpoint processmoduleconfig. Therefore it seems logical to use the same term for the variables here as well: ProcessModuleConfig
conf/update.go
Outdated
|
|
||
| // ConfMap is the representation of a config file with sections that are divided by headers (map[header] == section) | ||
| // each section consists of key value pairs. | ||
| type ConfMap map[string]map[string]string |
There was a problem hiding this comment.
Seems like this is the process module configuration. Why not name it like that?
There was a problem hiding this comment.
so I renamed stuff to ProcessModuleConfig, but left the ConfMap the same because I renamed the package to processmoduleconfig and naming it processmoduleconfig.ProcessModuleConfig feels very redundant :)
chrismuellner
approved these changes
Nov 22, 2021
0sewa0
added a commit
that referenced
this pull request
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic idea is that after the csi driver downloads a oneagent version(zip) then it updates the
ruxitagentproc.conffile within it according to what the settings on the tenant are.Details:
A new api was/will-be added on the tenant side to get the latest revision of the
ruxitagentproc.conffile, this file is read on startup by the standalone agent to do its magic.The csi driver uses this api to get the revision and store it in the tenants directory for use when a new agent version is downloaded. The csi driver also periodically checks for newer revisions, and if there is one then it updates the latest downloaded versions
ruxitagentproc.conffile again.To make multiple updates on a single version simple, during the initial update it makes a copy of the
ruxitagentproc.confnext to it with the name_ruxitagentproc.conf, so it uses_ruxitagentproc.confas the base for creating the latestruxitagentproc.conf. This can be done because in case of a new revision we get all the information again and not thestuff that changed from the previous revision.So the following is implemented:
dtclientis able to query the new endpoint for the latestruxitagentproc.confrevisionruxitagentproc.conffile.TODO:In the beginning I added a new (simple) database table to keep track which revision is cached for a given tenant, this is probably unnecessary so I will look into just removing it.