Validation webhook shows multiple errors #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the validation webhook only shows the first error it encounters which is not that user friendly if there are multiple problems with the Dynakube. (this would get worse if we add more validation checks)
This change makes it that the user will be given the list of validation errors.
Refactors the codebase by separating the validation checks and their test into separate files so we don't have an ever grooving file(+test file).
Adjusts the nodeSelector check so it recognizes when there are 2 dynakubes which deploys OS OneAgents where atleast 1 of them would deploy a oneagent daemonSet for all nodes (no nodeSelector is set)