Don't update k8s-settings object, if already present #3886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
K8S-11513
If we update the k8s settings object that already exists, for some reason causes data gaps.
We should avoid updating it, as it was done before v1.3
The diff looks a bit confusing:
settings.TotalCount > 0
check(and related calls) , before ther.dtc.CreateOrUpdateKubernetesSetting(...
callHow can this be tested?
There was a unit-test that was supposed to test for this.
Otherwise you have to make it update, and see gaps in the collected data