Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Slack bot token from e2e on-demand tests #3898

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

luhi-DT
Copy link
Collaborator

@luhi-DT luhi-DT commented Oct 7, 2024

Description

Remove Slack bot token from e2e on-demand tests and replace it with the webhook URL

How can this be tested?

Run e2e on demand tests and check slack notification

@chrismuellner chrismuellner added the ci Updates to the pipeline label Oct 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.38%. Comparing base (ca3d9b6) to head (adc98cc).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3898   +/-   ##
=======================================
  Coverage   64.38%   64.38%           
=======================================
  Files         372      372           
  Lines       20543    20543           
=======================================
  Hits        13227    13227           
  Misses       6034     6034           
  Partials     1282     1282           
Flag Coverage Δ
unittests 64.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luhi-DT luhi-DT enabled auto-merge (squash) October 8, 2024 06:04
@luhi-DT luhi-DT merged commit 42b27e3 into main Oct 8, 2024
14 checks passed
@luhi-DT luhi-DT deleted the fix/remove_slackbot_url branch October 8, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Updates to the pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants