Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorg codebase #402

Merged
merged 10 commits into from
Dec 9, 2021
Merged

Reorg codebase #402

merged 10 commits into from
Dec 9, 2021

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Dec 3, 2021

same as #391

chrismuellner
chrismuellner requested changes Dec 3, 2021
View reviewed changes
config/manifests/bases/dynatrace-operator.clusterserviceversion.yaml Outdated Show resolved Hide resolved
deploy/install.sh Outdated Show resolved Hide resolved
PROJECT Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
chrismuellner
chrismuellner reviewed Dec 9, 2021
View reviewed changes
Copy link
Collaborator

@chrismuellner chrismuellner left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the version package also be under src?

Moving everything that has go code under src would also make sense (so testing stuff as well)...

@0sewa0
Copy link
Contributor Author

0sewa0 commented Dec 9, 2021

the version package is something thats only purpose is to store the version of the operator, we set it during the build process, and we only read it in the go code, so I felt that its fine to be left out

@0sewa0 0sewa0 merged commit 8d3c3e7 into master Dec 9, 2021
@0sewa0 0sewa0 deleted the refactor/reorg-codebase branch December 9, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismuellner chrismuellner chrismuellner approved these changes

@luhi-DT luhi-DT Awaiting requested review from luhi-DT

@meik99 meik99 Awaiting requested review from meik99

@gkrenn gkrenn Awaiting requested review from gkrenn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0sewa0 @chrismuellner