Add option for selfregistering activegate #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismuellner
requested changes
Dec 23, 2021
src/controllers/activegate/reconciler/automaticapimonitoring/reconciler.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/automaticapimonitoring/reconciler.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/automaticapimonitoring/reconciler.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/automaticapimonitoring/reconciler.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/automaticapimonitoring/reconciler.go
Outdated
Show resolved
Hide resolved
fabwer
force-pushed
the
feature/selfregistering-activegate
branch
from
2ebfe56
to
be7d0ef
Compare
chrismuellner
changed the title
0sewa0
requested changes
Jan 3, 2022
src/controllers/activegate/reconciler/automaticapimonitoring/reconciler.go
Outdated
Show resolved
Hide resolved
|
Please rebase on master so you have the Github Actions run. |
|
You should update the tests, now that you removed the checks I asked some of your tests are failing. |
- Added api client for monitored entities and settings - Added reconciler to trigger the automatic kubernetes api monitoring to create kubernetes settings for the given kube-system uuid - Added conditions (annotation and capabilities) to check whether automatic api monitoring should be executed - Added appropriate tests
- Adapted PR according to the requested changes
- Removes unnecessary checks
- Removes unnecessary tests
fabwer
force-pushed
the
feature/selfregistering-activegate
branch
from
900f96e
to
4dea336
Compare
|
Unfortunate misclick 😅 |
- Move method to appropriate test file
# Conflicts: # src/controllers/dynakube/dynakube_controller_test.go
- Update test to use new test setup methods
0sewa0
reviewed
Jan 5, 2022
0sewa0
reviewed
Jan 5, 2022
0sewa0
reviewed
Jan 5, 2022
0sewa0
reviewed
Jan 5, 2022
0sewa0
reviewed
Jan 5, 2022
0sewa0
reviewed
Jan 5, 2022
- Refactors method to better reflect the usage
fabwer
force-pushed
the
feature/selfregistering-activegate
branch
from
e576ae7
to
226d754
Compare
0sewa0
previously approved these changes
Jan 5, 2022
chrismuellner
requested changes
Jan 7, 2022
src/controllers/activegate/reconciler/automaticapimonitoring/reconciler.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/automaticapimonitoring/reconciler.go
Outdated
Show resolved
Hide resolved
src/controllers/activegate/reconciler/automaticapimonitoring/reconciler.go
Outdated
Show resolved
Hide resolved
- Improves logging - Refactors method to better reflect the functionality
chrismuellner
approved these changes
Jan 10, 2022
0sewa0
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Kubernetes endpoint configuration creation logic to the Dynatrace operator to be available in the release 0.4.0 as an opt-in feature.