Remove static manifests and replace with helm charts #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meik99
requested review from
gkrenn,
0sewa0,
chrismuellner,
DTMad,
waodim and
luhi-DT
0sewa0
reviewed
Jan 5, 2022
Makefile
Outdated
|
|
||
| # Generate kubernetes.yaml | ||
| helm template dynatrace-operator config/helm/chart/default --namespace dynatrace --set platform="kubernetes" --set autoCreateSecret=false --set operator.image="quay.io/dynatrace/dynatrace-operator:snapshot" > config/deploy/kubernetes/kubernetes.yaml | ||
| sed -i '/app.kubernetes.io/d' config/deploy/kubernetes/kubernetes.yaml |
There was a problem hiding this comment.
does not work on mac
replaced it with:
sed -i '.original' -e ...
seems to have fixed it
There was a problem hiding this comment.
|
When I checked out the branch I had 2 weird files that I see no use of:
Is this because git derped a bit, or I found something 😅 |
|
|
added default platform moved setting image from kustomize to helm template
0sewa0
previously approved these changes
Jan 10, 2022
0sewa0
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effectively merges the helm-charts repository with the DTO repository.
Changes makefile to generate manifests from the charts.
The helm charts themselves have not been changed, only merged from their repository