Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes daemonset deletion issue #505

Merged
merged 3 commits into from
Jan 27, 2022
Merged

Fixes daemonset deletion issue #505

merged 3 commits into from
Jan 27, 2022

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Jan 26, 2022

Daemonset is not deleted by the operator because of a naming mismatch

@0sewa0 0sewa0 added the bug Something isn't working label Jan 26, 2022
@chrismuellner
Copy link
Collaborator

We should probably add a test for this 🙂

@0sewa0 0sewa0 enabled auto-merge (squash) January 27, 2022 14:29
@0sewa0 0sewa0 merged commit 290b87d into master Jan 27, 2022
@chrismuellner chrismuellner mentioned this pull request Jan 31, 2022
Merged
@chrismuellner chrismuellner deleted the bugfix/delete-osagent-daemonset branch February 2, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhi-DT luhi-DT luhi-DT approved these changes

@chrismuellner chrismuellner Awaiting requested review from chrismuellner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0sewa0 @chrismuellner @luhi-DT