Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes custom StatsD and EEC images in DynaKube ActiveGate spec #546

Merged
merged 5 commits into from
Feb 14, 2022

Conversation

toszr
Copy link
Contributor

@toszr toszr commented Feb 8, 2022

It is now possible to customize EEC & StatsD Docker images using feature flags feature-custom-eec-image & feature-custom-statsd-image. This is useful for customers who maintain private registries with Dynatrace images (and necessary for the time being until EEC & StatsD images are integrated with Dynatrace Docker registry).

CRD changes will follow once the DynaKube format is more stable.

# ...
apiVersion: dynatrace.com/v1beta1
kind: DynaKube
metadata:
  annotations:
    "alpha.operator.dynatrace.com/feature-custom-eec-image": "registry.lab.dynatrace.org/eec/dynatrace-eec:latest"
    "alpha.operator.dynatrace.com/feature-custom-statsd-image": "registry.lab.dynatrace.org/datasource/dynatrace-datasource-statsd:latest"
# ...

@toszr toszr requested review from a team February 8, 2022 09:39
@toszr toszr self-assigned this Feb 8, 2022
@toszr toszr added the activegate Changes related to Activegate label Feb 8, 2022
@toszr toszr requested review from mjgrzybek and aorcholski and removed request for a team February 8, 2022 09:42
Copy link
Collaborator

@chrismuellner chrismuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These images should be set by feature flag/annotation and not in the CR

@toszr toszr requested a review from mjgrzybek February 8, 2022 10:31
@toszr
Copy link
Contributor Author

toszr commented Feb 8, 2022

These images should be set by feature flag/annotation and not in the CR

Why? They are customer-facing, same as the ActiveGate image property in the DynaKube CR. As I learned, some customers prefer to perform manual version upgrades and the same is true for image versions.

@chrismuellner
Copy link
Collaborator

chrismuellner commented Feb 8, 2022

These images are not yet available on the registry, so having the configurable allows us to test and use them without having to change the whole CR.
We can talk about adding them to the CR at a later stage, but for now configuring them via annotations is enough.

@toszr
Copy link
Contributor Author

toszr commented Feb 10, 2022

OK, it's a small change I can fit into the first release. Be it annotations then (custom-eec-image, custom-statsd-image)

@toszr toszr force-pushed the feature/statsd-ingest--custom-StatsD-images branch from 33fba0d to e6c9c1f Compare February 10, 2022 20:37
@toszr toszr dismissed chrismuellner’s stale review February 10, 2022 20:40

Solved (switched from DynaKube properties to feature flags for EEC/StatsD images)

src/api/v1beta1/properties.go Outdated Show resolved Hide resolved
src/api/v1beta1/properties.go Show resolved Hide resolved
src/controllers/dynakube/updates/version.go Outdated Show resolved Hide resolved
@chrismuellner
Copy link
Collaborator

PR Description should be updated to reflect move to annotations

@toszr
Copy link
Contributor Author

toszr commented Feb 14, 2022

PR Description should be updated to reflect move to annotations

Good catch, thanks, done.

@toszr toszr force-pushed the feature/statsd-ingest--custom-StatsD-images branch from 64b49e8 to a4745aa Compare February 14, 2022 13:12
@toszr toszr force-pushed the feature/statsd-ingest--custom-StatsD-images branch from a4745aa to 04c5518 Compare February 14, 2022 13:17
@toszr toszr merged commit a335cdd into master Feb 14, 2022
@toszr toszr deleted the feature/statsd-ingest--custom-StatsD-images branch February 14, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activegate Changes related to Activegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants