-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposes custom StatsD and EEC images in DynaKube ActiveGate spec #546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These images should be set by feature flag/annotation and not in the CR
Why? They are customer-facing, same as the ActiveGate |
These images are not yet available on the registry, so having the configurable allows us to test and use them without having to change the whole CR. |
OK, it's a small change I can fit into the first release. Be it annotations then ( |
33fba0d
to
e6c9c1f
Compare
Solved (switched from DynaKube properties to feature flags for EEC/StatsD images)
src/controllers/activegate/reconciler/statefulset/container_statsd_test.go
Show resolved
Hide resolved
PR Description should be updated to reflect move to annotations |
Good catch, thanks, done. |
64b49e8
to
a4745aa
Compare
a4745aa
to
04c5518
Compare
It is now possible to customize EEC & StatsD Docker images using feature flags
feature-custom-eec-image
&feature-custom-statsd-image
. This is useful for customers who maintain private registries with Dynatrace images (and necessary for the time being until EEC & StatsD images are integrated with Dynatrace Docker registry).CRD changes will follow once the DynaKube format is more stable.