Change crdApplied to required for google marketplace #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkrenn
previously requested changes
Feb 21, 2022
There was a problem hiding this comment.
Have you tested this? - For me the install script does not seem to enforce setting the enum.
Btw. please update upload_test.sh - The path to the crd does no longer exists => Should be kubectl apply -k https://github.com/Dynatrace/dynatrace-operator/config/crd now
meik99
reviewed
Mar 24, 2022
Co-authored-by: Michael Rynkiewicz <michaelrynkiewicz3@gmail.com>
|
there is a conflict according to github |
…natrace/dynatrace-operator into feature/change-crdApplied-to-required
chrismuellner
changed the title
0sewa0
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.