Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Extension Controller/StatsD logs to the ActiveGate support archive #561

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

toszr
Copy link
Contributor

@toszr toszr commented Feb 14, 2022

ActiveGate offers the option to collect a support archive remotely from Debug UI (or the user-facing UI). It is useful when there is no log monitoring enabled in the cluster.

This PR links relevant directories between ActiveGate, Extension Controller and StatsD data source containers using volume mounts so that ActiveGate automatically picks up EEC/StatsD logs when a support archive is generated.

@toszr toszr self-assigned this Feb 14, 2022
@toszr toszr added the activegate Changes related to Activegate label Feb 14, 2022
@toszr toszr requested review from mjgrzybek, aorcholski and a team February 14, 2022 15:36
@0sewa0
Copy link
Contributor

0sewa0 commented Feb 15, 2022

Just so I understand correctly:
We mount 2 new emptyDir volumes, 1 for stasd logs and 1 for eec logs.
the stasd container can write to its log volume and can read from the eec logs volume
the eec container can write to its log volume and can read from the stasd logs volume
the activegate container can only read from both.

why does the stasd container need to be able to read the logs of the eec and visa-versa ?

@toszr
Copy link
Contributor Author

toszr commented Feb 15, 2022

Close, but it's not exactly what I implemented.

  • ActiveGate needs ro access to both EEC and StatsD logs (because it must collect them).
  • EEC needs access to its own logs volume (rw) but in order to maintain bare metal deployment consistency I made it aware (ro) of data source's logs as well. It's for convenience, too. (+2 new volume mounts: dataSourceStatsdLogs and eecLogs.)
  • StatsD only writes its own logs which it must expose to EEC and ActiveGate (does not need access to EEC logs, so only 1 extra volume is mounted: dataSourceStatsdLogs).

In theory, I could get rid of the StatsD logs volume mount in the EEC container and it shouldn't affect the deployment. In practice I preferred to keep it consistent with plain OneAgent/ActiveGate deployment modes (where EEC is responsible for saving/rotating data source logs).

@toszr toszr force-pushed the feature/statsd-ingest--logs-in-AG-support-archive branch from dab2594 to b268ee7 Compare February 16, 2022 11:13
@toszr toszr merged commit 5924cb2 into master Feb 16, 2022
@toszr toszr deleted the feature/statsd-ingest--logs-in-AG-support-archive branch February 16, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activegate Changes related to Activegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants