Add validity check for certificates on webhook startup #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhi-DT
requested review from
gkrenn,
0sewa0,
chrismuellner,
mjgrzybek and
aorcholski
0sewa0
reviewed
Feb 22, 2022
gkrenn
reviewed
Feb 23, 2022
gkrenn
reviewed
Feb 23, 2022
0sewa0
approved these changes
Mar 4, 2022
chrismuellner
pushed a commit
that referenced
this pull request
Mar 8, 2022
* Add validity check on webhook startup * Fix unit tests * Revert imports * Add constants from certificates controller (cherry picked from commit b02abbb)
chrismuellner
pushed a commit
that referenced
this pull request
Mar 9, 2022
* Add validity check on webhook startup * Fix unit tests * Revert imports * Add constants from certificates controller (cherry picked from commit b02abbb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a customer has an old certificate in the dynatrace namespace, the webhook will grab that cert and use it until the first renewal of his certificates (after 6 hours), because the validity is not checked, when the webhook grabs the certificates from the secret.
Webhook won't accept any connections/allow pod creations until it reloads certificates, which is after 6 hours. But the new certificates would be already in the cluster in a matter of minutes.
Therefore we should also check if the certificates are valid long enough, if the webhook starts.