Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Includes DT_STATSD_INGEST_URL in the endpoint.properties file injected to pods #594

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Includes DT_STATSD_INGEST_URL in the endpoint.properties file injected to pods #594

merged 2 commits into from
Feb 23, 2022

Conversation

toszr
Copy link
Contributor

@toszr toszr commented Feb 22, 2022

If statsd-ingest capability is enabled for ActiveGate, endpoint.properties file is enhanced with

DT_STATSD_INGEST_URL=dynakube-activegate.dynatrace:18125

It's used to discover StatsD service endpoint in the cluster (similar to metrics-ingest except for StatsD there is no token).

@toszr toszr added the activegate Changes related to Activegate label Feb 22, 2022
@toszr toszr requested review from mjgrzybek, aorcholski and a team February 22, 2022 14:56
@toszr toszr self-assigned this Feb 22, 2022
@toszr toszr force-pushed the feature/statsd-ingest--enhanced-endpoint-properties branch 2 times, most recently from 39d34ef to 722ffa1 Compare February 23, 2022 11:39
@toszr toszr force-pushed the feature/statsd-ingest--enhanced-endpoint-properties branch from 722ffa1 to 8d90e2e Compare February 23, 2022 13:32
0sewa0
0sewa0 reviewed Feb 23, 2022
View reviewed changes
Copy link
Contributor

@0sewa0 0sewa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, there is a conflict in the tests

@toszr toszr force-pushed the feature/statsd-ingest--enhanced-endpoint-properties branch from 8d90e2e to 2264061 Compare February 23, 2022 15:38
@toszr toszr force-pushed the feature/statsd-ingest--enhanced-endpoint-properties branch from 2264061 to c0f1e06 Compare February 23, 2022 15:40
@toszr
Copy link
Contributor Author

toszr commented Feb 23, 2022

looks good, there is a conflict in the tests

Yikes! Had to move the constants to activegate/capability/config.go to avoid package name clash.

Might make sense to rethink ActiveGate file and package structure, similar to what @0sewa0 did with other controllers (why is there a controllers/activegate and controllers/dynakube/activegate?). Something in the plans, @mjgrzybek @aorcholski?

@toszr toszr requested a review from 0sewa0 February 23, 2022 15:50
@toszr toszr merged commit b67d1a9 into master Feb 23, 2022
@0sewa0
Copy link
Contributor

0sewa0 commented Feb 23, 2022

Might make sense to rethink ActiveGate file and package structure

PLS YEEEEEES 😆

@toszr toszr deleted the feature/statsd-ingest--enhanced-endpoint-properties branch February 23, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0sewa0 0sewa0 0sewa0 approved these changes

@mjgrzybek mjgrzybek Awaiting requested review from mjgrzybek

@aorcholski aorcholski Awaiting requested review from aorcholski

@chrismuellner chrismuellner Awaiting requested review from chrismuellner

Assignees

@toszr toszr

Labels
activegate Changes related to Activegate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toszr @0sewa0 @chrismuellner