Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to distroless base image #596

Merged
merged 15 commits into from
Mar 11, 2022
Merged

Switch to distroless base image #596

merged 15 commits into from
Mar 11, 2022

Conversation

chrismuellner
Copy link
Collaborator

@chrismuellner chrismuellner commented Feb 22, 2022

  • Explicitly set image versions for builder image and base image
  • Update livenessprobe and registrar binaries
  • Switch to smaller base image without package manager

Closes #531

@chrismuellner chrismuellner added the core Changes to core functionality of the Operator label Feb 22, 2022
luhi-DT
luhi-DT previously approved these changes Feb 22, 2022
gkrenn
gkrenn previously approved these changes Feb 23, 2022
Copy link
Contributor

@0sewa0 0sewa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the csi driver doesn't work, I guess it uses the mount command that is not part of the distroless image

{"level":"info","ts":"2022-02-23T15:10:02.413Z","logger":"csi-driver","msg":"publishing volume","csiMode":"app","target":"/var/lib/kubelet/pods/d18175ca-0eac-4629-8ef7-2f35f4a954c3/volumes/kubernetes.io~csi/oneagent-bin/mount","fstype":"","readonly":false,"volumeID":"csi-806275e95d7941da0bb2b29c956fc2197b348e65338384ffcd12fa683c033099","attributes":{"csi.storage.k8s.io/ephemeral":"true","csi.storage.k8s.io/pod.name":"java-glibc-56978775fb-mvgzh","csi.storage.k8s.io/pod.namespace":"java-sample","csi.storage.k8s.io/pod.uid":"d18175ca-0eac-4629-8ef7-2f35f4a954c3","csi.storage.k8s.io/serviceAccount.name":"default","dynakube":"dynakube","mode":"app"},"mountflags":[]}
        /go/pkg/mod/google.golang.org/grpc@v1.43.0/server.go:921","ts":"2022-02-23T15:10:01.303Z"}E0223 15:10:02.413837       1 mount_linux.go:150] Mount failed: exec: "mount": executable file not found in $PATH
Mounting command: mount
Mounting arguments: -t overlay -o lowerdir=/data/zib50933/bin/1.237.0.20220223-091210,upperdir=/data/zib50933/run/csi-806275e95d7941da0bb2b29c956fc2197b348e65338384ffcd12fa683c033099/var,workdir=/data/zib50933/run/csi-806275e95d7941da0bb2b29c956fc2197b348e65338384ffcd12fa683c033099/work overlay /data/zib50933/run/csi-806275e95d7941da0bb2b29c956fc2197b348e65338384ffcd12fa683c033099/mapped
Output: 
{"error":"rpc error: code = Internal desc = failed to mount oneagent volume: mount failed: exec: \"mount\": executable file not found in $PATH
Mounting command: mount

@gkrenn gkrenn dismissed stale reviews from luhi-DT and themself via a69c8b1 March 4, 2022 11:42
@gkrenn gkrenn self-requested a review March 4, 2022 11:45
gkrenn
gkrenn previously approved these changes Mar 4, 2022
Copy link
Contributor

@gkrenn gkrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add glibc versions of mount/umount
  • Fix livenessprobe of csi registrar

@luhi-DT @chrismuellner

@gkrenn gkrenn merged commit 47f91cd into master Mar 11, 2022
@gkrenn gkrenn deleted the feature/distroless branch March 11, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to core functionality of the Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile should also apply latest security updates to base image
4 participants