Removes statsd-ingest dependency on metrics-ingest #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismuellner
previously requested changes
Feb 25, 2022
toszr
force-pushed
the
feature/statsd-ingest--remove-dependency-on-metrics-ingest
branch
from
99313f8
to
771dc55
Compare
toszr
force-pushed
the
feature/statsd-ingest--remove-dependency-on-metrics-ingest
branch
from
532485e
to
f4ff7ad
Compare
toszr
force-pushed
the
feature/statsd-ingest--remove-dependency-on-metrics-ingest
branch
from
f4ff7ad
to
6e9fedd
Compare
|
Do you have any further comments or can we move it forward? |
Fixed unit tests, always set metrics ingest url/token if data ingest is enabled
…rics-ingest is disabled
toszr
force-pushed
the
feature/statsd-ingest--remove-dependency-on-metrics-ingest
branch
from
2ef6322
to
6a4704e
Compare
mjgrzybek
approved these changes
Mar 3, 2022
toszr
deleted the
feature/statsd-ingest--remove-dependency-on-metrics-ingest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, ActiveGate capability
statsd-ingestenhancedmetrics-ingestwith StatsD-related port, endpoint properties and containers.This changeset makes it independently controlled (i.e. it should be possible to define
statsd-ingestalone or together withmetrics-ingest).