Removes admission.Errored responses from podmutator webhook #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhi-DT
requested changes
Mar 8, 2022
luhi-DT
approved these changes
Mar 8, 2022
chrismuellner
pushed a commit
that referenced
this pull request
Mar 8, 2022
(cherry picked from commit 3dff522)
chrismuellner
pushed a commit
that referenced
this pull request
Mar 9, 2022
(cherry picked from commit 3dff522)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On OLM the namespaceSelector in the
MutatingWebhookConfigurationis ignored. This leads to the Webhook intercepting Pod Creation for every pod in the Cluster, independent of the namespaceSelector in the Dynakube and the corresponding label on the namespace managed by the Operator.The failurePolicy is set to ignore, with a timeout of 2s, but since the Webhook returns an error response before the 2s are up, the pod is blocked from being created.
How can this be tested?
No matter what, the webhook will not stop the scheduling of a pod because of an error, instead the error's text should be in the message.
Checklist