Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple osagents on the same node #608

Merged
merged 4 commits into from
Mar 7, 2022

Conversation

mjgrzybek
Copy link
Contributor

@mjgrzybek mjgrzybek commented Mar 2, 2022

Description

Added a dynakube annotation alpha.operator.dynatrace.com/feature-multiple-osagents-on-node allowing multitenant hostMonitoring (defaults to "false").
OneAgent mounts:

  • node's root fs as read-only volume
  • csi volume as read-write, unique per tenant

If dynakube annotation alpha.operator.dynatrace.com/feature-multiple-osagents-on-node == true, nodeSelector validation is disabled.

How can this be tested?

2+ dynakube objects with hostMonitoring enabled (or cloudNativeFullStack with namespaceSelector set so that there is no namespace monitored by more than one dynakube).
OneAgent pods are expected to have running status.
Note: currently OneAgent prevents two instances from running on the same host.

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@mjgrzybek mjgrzybek requested review from 0sewa0 and a team March 2, 2022 15:53
@mjgrzybek mjgrzybek added feature oneagent Changes related to Oneagent labels Mar 2, 2022
@mjgrzybek mjgrzybek force-pushed the feature/multiple-osagents-on-the-same-node branch from f726bcc to 6a12620 Compare March 2, 2022 15:59
@mjgrzybek mjgrzybek enabled auto-merge (squash) March 3, 2022 09:04
0sewa0
0sewa0 previously approved these changes Mar 4, 2022
@mjgrzybek mjgrzybek force-pushed the feature/multiple-osagents-on-the-same-node branch from 08382de to 41c18e8 Compare March 7, 2022 08:32
@mjgrzybek mjgrzybek requested a review from 0sewa0 March 7, 2022 08:46
@mjgrzybek mjgrzybek merged commit 55d1e0d into master Mar 7, 2022
@mjgrzybek mjgrzybek deleted the feature/multiple-osagents-on-the-same-node branch March 7, 2022 10:24
chrismuellner pushed a commit that referenced this pull request Mar 8, 2022
* FeatureEnableMultipleOsAgentsOnNode added

* nodeSelector ignored if ff-multiple-osagents-on-node enabled

* unit tests

(cherry picked from commit 55d1e0d)
chrismuellner pushed a commit that referenced this pull request Mar 9, 2022
* FeatureEnableMultipleOsAgentsOnNode added

* nodeSelector ignored if ff-multiple-osagents-on-node enabled

* unit tests

(cherry picked from commit 55d1e0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oneagent Changes related to Oneagent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants