Removes "alpha." from the feature flags + adds deprecation warning for old flags #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgrzybek
reviewed
Mar 3, 2022
0sewa0
changed the title
toszr
previously approved these changes
Mar 3, 2022
toszr
reviewed
Mar 4, 2022
0sewa0
force-pushed
the
feature/migrate-feature-flags
branch
from
08eb85f
to
0196fe4
Compare
mjgrzybek
approved these changes
Mar 17, 2022
eogden93
added a commit
to eogden93/dynatrace-operator
that referenced
this pull request
Mar 17, 2022
As per PR Dynatrace#611 this change removes `alpha.` from feature flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature flag shouldn't have the
alpha.prefix, because they don't mean anything.And moving them to
betaor something else will not improve them just introduce more complex logic in the code.If we want to deprecate 1 or a set of feature-flags we can do it using the validation webhook.
But because some user might already use some of these we should support them for a release or two, so this PR enables the use of both.
There is an exception when it comes to the new
statsdfeature-flags as they were not released before, so we don't have to support it there.Also adds a warning in the webhook, if there is a deprecated annotation present in the annotation of the dynakube.
How can this be tested?
Try to apply a dynakube, with a deprecated feature-flag, it should work but you should also get a warning.
Then do the same but without the
alpha.part, it should still work, but without the warning on the applyChecklist