Fix phase field not updating #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismuellner
added
bug
mjgrzybek
reviewed
Mar 7, 2022
meik99
suggested changes
Mar 8, 2022
0sewa0
reviewed
Mar 8, 2022
src/testing/e2e/integrationtests/oneagent_controller_integration_test.go
Outdated
Show resolved
Hide resolved
|
The phase field is updated initially while the deamonset is first deployed. However, if a oneagent pod is deleted after the phase has been set to running, it is not updated to read "Deploying" again. Is this expected behaviour? |
|
It should reset the phase to "Deploying" as the phase is determined on every oneagent reconcile which happens on every dynakube reconcile. The phase field in general is not implemented well, a more structured phase handling is done in the following PR: #609 |
0sewa0
approved these changes
Mar 8, 2022
meik99
approved these changes
Mar 9, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The oneagent reconciler references the wrong daemonset and therefore never updates the phase field.
How can this be tested?
Deploy full stack monitoring and watch the phase field. => Should be "Running" after dynakube reconciliation.
Checklist