Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added opt-in feature flag AnnotationFeatureEnableActivegateRawImage #616

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

mjgrzybek
Copy link
Contributor

@mjgrzybek mjgrzybek commented Mar 7, 2022

Description

Added a feature flag called AnnotationFeatureEnableActivegateRawImage. (=false by default).
It allows customer to opt-in to use raw AG image.

How can this be tested?

  1. Create dynakube with AG spec
  2. check if it works with no annotation
  3. add AnnotationFeatureEnableActivegateRawImage = "false", operator should work as in point 1
  4. change AnnotationFeatureEnableActivegateRawImage = "true" and check if <dynakube>-activegate-tenant-secret is created and if it's mounted in a pod as:
  • token secret: /var/lib/dynatrace/secrets/tokens/tenant-token
  • env vars: DT_SERVER, DT_TENANT

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@mjgrzybek mjgrzybek added the activegate Changes related to Activegate label Mar 7, 2022
@mjgrzybek mjgrzybek requested review from chrismuellner and a team March 7, 2022 14:39
@mjgrzybek mjgrzybek force-pushed the feature/ag-raw-img-opt-in branch 3 times, most recently from d682969 to 126adc2 Compare March 7, 2022 14:55
@mjgrzybek mjgrzybek enabled auto-merge (squash) March 7, 2022 16:14
0sewa0
0sewa0 previously approved these changes Mar 8, 2022
@mjgrzybek mjgrzybek merged commit d1b997d into master Mar 9, 2022
@mjgrzybek mjgrzybek deleted the feature/ag-raw-img-opt-in branch March 9, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activegate Changes related to Activegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants