Adds database overview to the logs of the csi driver on error and startup #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkrenn
reviewed
Mar 18, 2022
| @@ -95,6 +95,22 @@ const ( | |||
| WHERE TenantUUID = ?; | |||
| ` | |||
|
|
|||
| // GET ALL | |||
| getAllDynakubesStatement = ` | |||
| SELECT Name, TenantUUID, LatestVersion | |||
There was a problem hiding this comment.
Would remove one tab to be identical with the previous statements
gkrenn
reviewed
Mar 18, 2022
|
|
||
| dynakubes, err := db.GetAllDynakubes() | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, 2, len(dynakubes)) |
There was a problem hiding this comment.
Would even check if the returned objects are dk1 & dk2
Similar for the next tests
gkrenn
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't have a good way to check whats in the database, so on startup after the correction logic runs we log the content of the database. We also do this when the csi server stops.
How can this be tested?
When you deploy the csi driver, in the logs there should be a line around the top (~3 line or so) that has the contents of the database on that node.
Checklist