Fix nil panic introduced by installer rework #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this bug was introduced when the extraction/rework of the installer in the csi driver happend. If the processmoduleconfig endpoint is not present on the tenant we would get a nil panic in the csi provisioner no matter what.
How can this be tested?
In a new cluster, with a tenant that doesn't have the processmoduleconfig endpoint, deploy cloudNative, the csi driver should not panic and should mount the volume successfully. (if hostGroup is used it should be added to the ruxitagentproc.conf)
Checklist