Enables relevant ActiveGate service ports based on capability requirements

[toszr]

Description

This changeset solves the problem deploying ActiveGate with capabilities which require a ClusterIP service (routing, dynatrace-api) but without metrics-ingest.

Before that, defining routiung and/or dynatrace-api without metrics-ingest caused deployment failure due to AG service not exposing HTTP(S) ports, with stack trace similar to:

{"error":"Service \"***-activegate\" is invalid: spec.ports: Required value","level":"error","logger":"main.controller.dynakube","msg":"Reconciler error","name":"***","namespace":"dynatrace","reconciler group":"dynatrace.com","reconciler kind":"DynaKube","stacktrace":"Service \"***-activegate\" is invalid: spec.ports: Required value                                                                    
github.com/Dynatrace/dynatrace-operator/src/controllers/activegate/reconciler/capability.(*Reconciler).createServiceIfNotExists                                                                                               
        /app/src/controllers/activegate/reconciler/capability/reconciler.go:173                                                                                                                                               
github.com/Dynatrace/dynatrace-operator/src/controllers/activegate/reconciler/capability.(*Reconciler).Reconcile                                                                                                              
        /app/src/controllers/activegate/reconciler/capability/reconciler.go:140                                                                                                                                               
github.com/Dynatrace/dynatrace-operator/src/controllers/dynakube.(*DynakubeController).reconcileActiveGateCapabilities                                                                                                        
        /app/src/controllers/dynakube/dynakube_controller.go:320                                                                                                                                                              
github.com/Dynatrace/dynatrace-operator/src/controllers/dynakube.(*DynakubeController).reconcileActiveGate                                                                                                                    
        /app/src/controllers/dynakube/dynakube_controller.go:292                                                                                                                                                              
github.com/Dynatrace/dynatrace-operator/src/controllers/dynakube.(*DynakubeController).reconcileDynaKube                                                                                                                      
        /app/src/controllers/dynakube/dynakube_controller.go:212                                                                                                                                                              
github.com/Dynatrace/dynatrace-operator/src/controllers/dynakube.(*DynakubeController).Reconcile                                                                                                                              
        /app/src/controllers/dynakube/dynakube_controller.go:123                                                                                                                                                              
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile                                                                                                                                                
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:114                                                                                                                          
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler                                                                                                                                         
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:311                                                                                                                          
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem                                                                                                                                      
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:266                                                                                                                          
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2                                                                                                                                            
        /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.0/pkg/internal/controller/controller.go:227                                                                                                                          
runtime.goexit                                                                                                                                                                                                                
        /usr/local/go/src/runtime/asm_amd64.s:1581    

How can this be tested?

Automatic

Run or inspect kuttl test scenario tests/activegate/routing.

Manual

To test the fix, experiment with ActiveGate capabilities making sure that the expected service ports are exposed (and the AG pod is ready):

• if routing, dynatrace-api and/or metrics-ingest capabilities are defined, ports http and https are exposed in dynakube-activegate
• if (and only if) statsd-ingest is enabled, port statsd is exposed in dynakube-activegate
• if statsd-ingest and at least one of routing, dynatrace-api and/or metrics-ingest are enabled, all the three ports are exposed (http, https, statsd)
• if ActiveGate is deployed with kubernetes-monitoring only, the AG service is not created at all dynakube-activegate (or is removed)

Checklist

• Unit tests have been updated/added
• PR is labeled accordingly