Decouple standalone and oneagent csi storage #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The host oneagent csi-storage doesn't get mounted while the standalone agent binary is not downloaded, which is not optimal.
To decouple these two:
The "LatestVersion" field of the Dynakube database entry is not needed for the oneagent-storage,
so now we add the Dynakube entry to the database while the "LatestVersion" is not set.
Therefore we can still stop the mount of the standalone agents if the version not set,
but we can move forward with mounting the oneagent-storage
How can this be tested?
Deploy cloudNative and see that the host oneagents get there containers created before the standalone binary is donwloaded (sample apps are still waiting).
Also there is a new error message in the sample app's event while the binary is downloading
version is not yet set, csi-provisioner hasn't finished setup yet for tenantChecklist