Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TopologySpreadConstraints support to ActiveGate spec #652

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

mjgrzybek
Copy link
Contributor

@mjgrzybek mjgrzybek commented Mar 18, 2022

Description

Dynakube supports settings TopologySpreadConstraints for ActiveGate pods.

How can this be tested?

This dynakube should work and replicas should be spread across different nodes, if available:

apiVersion: dynatrace.com/v1beta1
kind: DynaKube
metadata:
  name: dk
  namespace: dynatrace
spec:
  apiUrl: <api_url>
  activeGate:
    capabilities:
    - kubernetes-monitoring
    - routing
    replicas: 3
    topologySpreadConstraints:
    - maxSkew: 1
      topologyKey: topology.gke.io/zone      # depending on your environment
      whenUnsatisfiable: ScheduleAnyway
      labelSelector:
        matchLabels:
          app.kubernetes.io/component: activegate
          app.kubernetes.io/name: dynatrace-operator
          app.kubernetes.io/created-by: dk

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@mjgrzybek mjgrzybek added the activegate Changes related to Activegate label Mar 18, 2022
@mjgrzybek mjgrzybek requested review from luhi-DT and a team March 18, 2022 09:05
@mjgrzybek mjgrzybek force-pushed the feature/topology-spread-constraints branch from 9b2f21d to e09b19a Compare March 18, 2022 09:13
@mjgrzybek mjgrzybek force-pushed the feature/topology-spread-constraints branch from e09b19a to 79c91d6 Compare March 18, 2022 09:21
@mjgrzybek mjgrzybek merged commit f2db4ab into master Mar 18, 2022
@mjgrzybek mjgrzybek deleted the feature/topology-spread-constraints branch March 18, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
activegate Changes related to Activegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants