Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors address_of to use Go 1.18 generics #654

Merged
merged 6 commits into from
May 13, 2022
Merged

Refactors address_of to use Go 1.18 generics #654

merged 6 commits into from
May 13, 2022

Conversation

toszr
Copy link
Contributor

@toszr toszr commented Mar 18, 2022 •
edited

Description

Refactors address_of package to make use of the brand new Go 1.18 generics (see official tutorial).

How can this be tested?

make lint && make test

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@toszr toszr added minor core Changes to core functionality of the Operator labels Mar 18, 2022
@toszr toszr requested review from mjgrzybek, aorcholski and a team March 18, 2022 11:15
@toszr toszr changed the title Refactor/go generics Refactors address_of to use Go 1.18 generics Mar 18, 2022
@luhi-DT luhi-DT closed this Apr 4, 2022
@toszr toszr reopened this Apr 27, 2022
@toszr toszr marked this pull request as ready for review April 27, 2022 14:06
@toszr toszr requested a review from mjgrzybek April 28, 2022 13:48
mjgrzybek
mjgrzybek previously approved these changes Apr 29, 2022
View reviewed changes
@toszr toszr enabled auto-merge (squash) April 29, 2022 11:31
@toszr toszr requested a review from mjgrzybek April 29, 2022 12:54
meik99
meik99 previously requested changes May 4, 2022
View reviewed changes
src/kubeobjects/address/address_test.go Outdated Show resolved Hide resolved
src/kubeobjects/address/address_test.go Outdated Show resolved Hide resolved
src/kubeobjects/address/address_test.go Outdated Show resolved Hide resolved
src/kubeobjects/address/address_test.go Outdated Show resolved Hide resolved
mjgrzybek
mjgrzybek previously approved these changes May 4, 2022
View reviewed changes
@mjgrzybek mjgrzybek dismissed meik99’s stale review May 13, 2022 06:55

Requested changes are applied

@toszr toszr merged commit d48fb4d into master May 13, 2022
@toszr toszr deleted the refactor/go-generics branch May 13, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luhi-DT luhi-DT luhi-DT approved these changes

@meik99 meik99 meik99 left review comments

@mjgrzybek mjgrzybek mjgrzybek left review comments

@aorcholski aorcholski Awaiting requested review from aorcholski

Assignees
No one assigned
Labels
core Changes to core functionality of the Operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@toszr @meik99 @mjgrzybek @luhi-DT @chrismuellner