Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveGate webserver's CA mounted properly in OneAgents pods #661

Merged
merged 5 commits into from
Mar 28, 2022
Merged

ActiveGate webserver's CA mounted properly in OneAgents pods #661

merged 5 commits into from
Mar 28, 2022

Conversation

mjgrzybek
Copy link
Contributor

@mjgrzybek mjgrzybek commented Mar 23, 2022 •
edited

Description

OneAgent expects ActiveGate CA cert to be mounted here: /mnt/dynatrace/certs/activegate/

How can this be tested?

  1. Create dynakubre cloudNativeFullstack monitoring enabled
  2. kubectl patch -ndynatrace dynakubes.dynatrace.com dynakube --type=json -p='[{"op":"replace", "path":"/spec/activeGate /tlsSecretName", "value":"dk-certs"}]'
  3. OneAgent pods should be in Running state eventually

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@mjgrzybek mjgrzybek added bug Something isn't working oneagent Changes related to Oneagent labels Mar 23, 2022
@mjgrzybek mjgrzybek requested review from 0sewa0 and a team March 23, 2022 07:11
@0sewa0
Copy link
Contributor

0sewa0 commented Mar 23, 2022

what happens if we are not running in read-only mode ?
shouldn't we use the "old" path or this path works in that case aswell ?

meik99
meik99 previously requested changes Mar 23, 2022
View reviewed changes
src/controllers/dynakube/oneagent/daemonset/daemonset.go Outdated Show resolved Hide resolved
src/controllers/dynakube/oneagent/daemonset/daemonset.go Outdated Show resolved Hide resolved
src/webhook/mutation/pod_mutator.go Outdated Show resolved Hide resolved
@mjgrzybek
Copy link
Contributor Author

mjgrzybek commented Mar 23, 2022 •
edited

what happens if we are not running in read-only mode ? shouldn't we use the "old" path or this path works in that case aswell ?

@0sewa0 depends on OneAgent version and this is why it's not yet backported to release-0.5 branch. Let's discuss it offline.

@mjgrzybek mjgrzybek force-pushed the bugfix/ca-cert-for-oneagents-master branch 4 times, most recently from 6ffd4a9 to a6a6e91 Compare March 23, 2022 12:52
@mjgrzybek mjgrzybek marked this pull request as draft March 24, 2022 08:29
@mjgrzybek mjgrzybek force-pushed the bugfix/ca-cert-for-oneagents-master branch 6 times, most recently from 13362ad to 1347cc5 Compare March 25, 2022 07:18
luhi-DT
luhi-DT previously requested changes Mar 25, 2022
View reviewed changes
Copy link
Collaborator

@luhi-DT luhi-DT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When should we merge those changes? When the Agent has the backport to look on both location?

src/api/v1beta1/properties.go Show resolved Hide resolved
src/webhook/mutation/pod_mutator.go Show resolved Hide resolved
@mjgrzybek mjgrzybek force-pushed the bugfix/ca-cert-for-oneagents-master branch 2 times, most recently from 0e24e85 to 59e703c Compare March 25, 2022 11:13
@mjgrzybek mjgrzybek force-pushed the bugfix/ca-cert-for-oneagents-master branch from 59e703c to 3afd223 Compare March 25, 2022 11:14
@mjgrzybek mjgrzybek marked this pull request as ready for review March 25, 2022 11:34
@mjgrzybek mjgrzybek enabled auto-merge (squash) March 25, 2022 11:34
@mjgrzybek mjgrzybek requested a review from meik99 March 25, 2022 11:34
@meik99 meik99 dismissed stale reviews from luhi-DT and themself March 28, 2022 11:00

outdated

@mjgrzybek mjgrzybek merged commit 627621b into master Mar 28, 2022
@mjgrzybek mjgrzybek deleted the bugfix/ca-cert-for-oneagents-master branch March 28, 2022 11:05
mjgrzybek added a commit that referenced this pull request Mar 28, 2022
@mjgrzybek
ActiveGate webserver's CA mounted properly in OneAgents pods (#661)
65f04fa
@mjgrzybek mjgrzybek mentioned this pull request Mar 28, 2022
Merged
2 tasks
mjgrzybek added a commit that referenced this pull request Mar 29, 2022
@mjgrzybek
ActiveGate webserver's CA mounted properly in OneAgents pods (#661) (#…
a3d1603 
…674)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0sewa0 0sewa0 0sewa0 approved these changes

@luhi-DT luhi-DT Awaiting requested review from luhi-DT

@meik99 meik99 Awaiting requested review from meik99

Assignees
No one assigned
Labels
bug Something isn't working oneagent Changes related to Oneagent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mjgrzybek @0sewa0 @meik99 @luhi-DT