Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mock client for ARM architecture #668

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Fix mock client for ARM architecture #668

merged 4 commits into from
Mar 29, 2022

Conversation

chrismuellner
Copy link
Collaborator

@chrismuellner chrismuellner commented Mar 25, 2022

Description

Mock client expected specific flavor in request which is only valid on amd architecture.

How can this be tested?

Run unit tests on ARM.

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@chrismuellner chrismuellner added the core Changes to core functionality of the Operator label Mar 25, 2022
@chrismuellner chrismuellner requested a review from a team as a code owner March 25, 2022 12:17
@0sewa0
Copy link
Contributor

0sewa0 commented Mar 25, 2022

Run unit tests on ARM.

Ok, how ? 😄

@chrismuellner chrismuellner enabled auto-merge (squash) March 28, 2022 10:09
Co-authored-by: Marcell Sevcsik <31651557+0sewa0@users.noreply.github.com>
@0sewa0
Copy link
Contributor

0sewa0 commented Mar 29, 2022

you have to import arch 😅

	"github.com/Dynatrace/dynatrace-operator/src/controllers/csi/provisioner/arch"

@chrismuellner chrismuellner merged commit e89504f into master Mar 29, 2022
@chrismuellner chrismuellner deleted the fix/arm-tests branch March 29, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to core functionality of the Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants