Simplifies the matchLabels for Oneagent daemonset #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -111,7 +111,7 @@ func TestLogGarbageCollector_modificationDateOlderThanTwoWeeks(t *testing.T) { | |||
| }) | |||
|
|
|||
| t.Run("is true for timestamp 14 days in past", func(t *testing.T) { | |||
| isOlder := isOlderThanTwoWeeks(time.Now().AddDate(0, 0, -14)) | |||
| isOlder := isOlderThanTwoWeeks(time.Now().AddDate(0, 0, -15)) | |||
There was a problem hiding this comment.
should this be in this PR?
There was a problem hiding this comment.
creating a separate PR for it would be to much work at this point IMO
There was a problem hiding this comment.
I don't quite get what the purpose of this change is, but I agree with @0sewa0, it's such a trivial change it doesn't really need its own PR. It's more like housekeeping
meik99
suggested changes
Mar 28, 2022
0sewa0
commented
Mar 28, 2022
| @@ -12,95 +12,74 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/client" | |||
| ) | |||
|
|
|||
| const ( | |||
There was a problem hiding this comment.
the diff looks scary, but I just refactored this according to the guidelines
0sewa0
commented
Mar 28, 2022
meik99
suggested changes
Mar 29, 2022
Comment on lines
+188
to
+191
| // buildMatchLabels produces a set of labels that | ||
| // don't change when switching between oneagent modes | ||
| // or during operator version update | ||
| // as matchLabels are not mutable on a Daemonset |
There was a problem hiding this comment.
I like this comment, it is good, well written, and useful
| @@ -12,95 +12,74 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/client" | |||
| ) | |||
|
|
|||
| const ( | |||
chrismuellner
changed the title
meik99
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The match labels shouldn't change between deployment modes or the operator will throw errors in case the mode is changed on the dynakube and the oneagent daemonset will not change unless deleted by hand.
How can this be tested?
The labels should change, but not the matchLabels
Checklist