Prunes the makefile #678
Merged
Prunes the makefile #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meik99
suggested changes
Mar 30, 2022
meik99
reviewed
Mar 30, 2022
meik99
reviewed
Mar 30, 2022
meik99
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames/refactors/prunes things in the makefile.
Removed commands that didn't work (properly) (or didn't make sense)
Introduced new targets instead of using
ifs and envvarsRenamed targets that were too vague, inaccurate or unhelpful
Didn't touch the image setting/switching logic. (I couldn't come up with a better solution)
How can this be tested?
Test out the commands, see if they work.
If removed one of your favourite command, pls comment which one was it and why do you use it 😄
Checklist