Remove version from matchLabels in Helm and Activegate
#683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismuellner
changed the title
matchLabels in Helm and Activegate
0sewa0
force-pushed
the
fix/matchLabels_everywhere
branch
from
aa9d799
to
a47c4ec
Compare
meik99
suggested changes
Apr 5, 2022
src/controllers/activegate/reconciler/statefulset/reconciler.go
Outdated
Show resolved
Hide resolved
0sewa0
force-pushed
the
fix/matchLabels_everywhere
branch
from
0097148
to
acc3a26
Compare
meik99
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No label that changes overtime should be part of the matchLabels as those are immutable. Also reintroduces the old labels to be only used as matchLabels for know, will be replaced in the future
How can this be tested?
After deploy, check if the deployments/daemonset/statefulsets have all the labels (which has the version, feature etc)
but the matchLabels should only have things that don't change (component, name)
Checklist