Add codeModulesImage field to Dynakube where CSI Driver is used #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you forgot to add general files like CRD and so on |
0sewa0
changed the title
chrismuellner
added
oneagent
0sewa0
requested changes
Apr 1, 2022
Co-authored-by: Marcell Sevcsik <31651557+0sewa0@users.noreply.github.com>
Co-authored-by: Marcell Sevcsik <31651557+0sewa0@users.noreply.github.com>
…o feature/add-image-field-csi
0sewa0
reviewed
Apr 1, 2022
…natrace-operator into feature/add-image-field-csi
chrismuellner
previously requested changes
Apr 7, 2022
0sewa0
reviewed
Apr 7, 2022
…natrace-operator into feature/add-image-field-csi
|
run |
0sewa0
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a image field in the dynakube with the modes enabled, which use the CSIDriver. The field is called "codeModulesImage".
How can this be tested?
Apply a dynakube with either cloudNativeFullStack enabled with the field "codeModulesImage" set or with applicationMonitoring enabled with the field "codeModulesImage" set. If one decides to apply a dynakube with applicationMonitoring enabled, useCSIDriver field set to false and with the "codeModulesImages" field set, the validation webhook responds with an error.
Checklist