Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image field for hostAgents to cloudNativeFullStack #689

Merged
merged 5 commits into from
Apr 6, 2022
Merged

Add image field for hostAgents to cloudNativeFullStack #689

merged 5 commits into from
Apr 6, 2022

Conversation

luhi-DT
Copy link
Collaborator

@luhi-DT luhi-DT commented Apr 4, 2022

Description

This PR adds an image field to cloudNativeFullstack and gives the possibility to add it in the CR. Before that PR it was not possible to set an image for the host agents when using cloudNativeFullStack.

How can this be tested?

  1. Pull the oneagent Image from your Tenant and push it to a private registry (Quay)
  2. Create a CR with cloudNative enabled and add the image you pushed to your private repository before
  3. Check if the daemonset and the oneAgents, which got rolled out have the correct image set

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@luhi-DT luhi-DT added the core Changes to core functionality of the Operator label Apr 4, 2022
@luhi-DT luhi-DT requested a review from a team as a code owner April 4, 2022 13:32
0sewa0
0sewa0 approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@0sewa0 0sewa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait for 0.6 branch to be created, or this is part of it ?

@luhi-DT luhi-DT merged commit 011498a into master Apr 6, 2022
@luhi-DT luhi-DT deleted the feature/add-image-field-to-cloudNative branch April 6, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0sewa0 0sewa0 0sewa0 approved these changes

Assignees
No one assigned
Labels
core Changes to core functionality of the Operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luhi-DT @0sewa0