Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activegate.customproperties.value when multi line string is used #691

Merged
merged 6 commits into from
Apr 6, 2022

Conversation

chrismuellner
Copy link
Collaborator

Description

When using a multi line string for customproperties.value in the values file, invalid yaml was generated by helm.

How can this be tested?

Use a values file that contains a multi line string in this section:

activeGate:
  capabilities:
  - kubernetes-monitoring
  customProperties:
    value: |
      [kubernetes_monitoring]
      key=value

Run the following command:

helm install dynatrace-operator config/helm/chart/default -f values.yaml --create-namespace -n dynatrace --dry-run

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@chrismuellner chrismuellner added bug Something isn't working helm Changes to helm templates or values file labels Apr 6, 2022
@chrismuellner chrismuellner requested a review from a team April 6, 2022 08:38
(cherry picked from commit 5b68fea)
@chrismuellner chrismuellner enabled auto-merge (squash) April 6, 2022 11:00
@chrismuellner chrismuellner merged commit ec56144 into release-0.5 Apr 6, 2022
@chrismuellner chrismuellner deleted the fix/helm-customproperties branch April 6, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working helm Changes to helm templates or values file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants