Fixes using wrong tag for immutable image when version is set #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meik99
added
bug
|
Should we have also an check in the validation webhook, that the version provided has a compatible and correct format? |
We could consider that as an additional feature. |
0sewa0
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
This PR truncates the build date of a supplied OneAgent version when used as a tag for the immutable image.
It implements the change for the
ImmutableOneAgentImage()DynaKube property.Which issue is fixed
When the OneAgent version is set in the custom resource and the CSI driver is used, the image cannot be pulled since the version has the wrong format for the image.
The CSI driver expects the version to be in a format like "1.231.288.20220218-170442". If the version is not in this format, the CSI driver cannot download it from the API since the version has to include the build date.
However, the same version field is used to overwrite the version tag for the oneagent images that are used. These image tags do not contain the build date.
Therefore, the version can only be correct for either the API or the Image tag.
How can this be tested?
Environment necessary
Fresh Kubernetes cluster
Recreating the error
On a fresh cluster,
create the dynatrace namespace,
deploy the operator from the master branch or use the 0.5 release,
create the dynakube secret,
modify a sample to use cloud native full stack and set the version field to a valid version, e.g., the one described above,
watch the pods fail due to a image pull back off error,
modify the sample to use a version without the build date and apply,
watch the pods be created successfully, however the CSI driver will fail in the logs due to the version being invalid
Confirming the fix
On a fresh cluster,
create the dynatrace namespace,
deploy the operator from fix/truncate-version-build-date branch,
create the dynakube secret,
modify a sample to use cloud native full stack and set the version field to a valid version, e.g., the one described above,
the pods should start successfully, the version tag should be the same as the one in the CR but without the build date,
the CSI driver does not show error logs regarding the version
Checklist