Add highavailability option for webhook via helm #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config/helm/chart/default/templates/Common/webhook/deployment-webhook.yaml
Outdated
Show resolved
Hide resolved
meik99
reviewed
Apr 8, 2022
config/helm/chart/default/templates/Common/webhook/deployment-webhook.yaml
Outdated
Show resolved
Hide resolved
meik99
approved these changes
Apr 11, 2022
waodim
added a commit
that referenced
this pull request
Apr 14, 2022
Co-authored-by: Christoph Muellner <33160506+chrismuellner@users.noreply.github.com>
waodim
added a commit
that referenced
this pull request
Apr 21, 2022
* Fix typo * Add highavailability option for webhook via helm (#713) Co-authored-by: Christoph Muellner <33160506+chrismuellner@users.noreply.github.com> * Readd image field Co-authored-by: Christoph Muellner <33160506+chrismuellner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new option for the webhook. The flag is called enableHighAvailability and can be found in the helm charts in the values.yaml file. Changes the replicas of the webhook deployment from 1 to 2 and also introduces a PodDisruptionBudget with minAvailable set to 1. Also topologySpreadConstraints are set.
How can this be tested?
Set the flag to true, render a chart and apply the output file.
Checklist