Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the deprecated feature-flag warning more precise #723

Merged
merged 4 commits into from
Apr 21, 2022

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Apr 13, 2022

Description

The original message for the deprecated feature-flag warning was a bit vague. This adds a bit more context.

How can this be tested?

Delpoy a dynakube with a feature-flag that has a alpha. prefix, and see the warning message in the command line

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@0sewa0 0sewa0 added the core Changes to core functionality of the Operator label Apr 13, 2022
@0sewa0 0sewa0 requested a review from a team as a code owner April 13, 2022 08:49
Copy link
Collaborator

@chrismuellner chrismuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefix should be changed to feature.dynatrace.com/... and warning message adjusted accordingly

Copy link
Contributor

@meik99 meik99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from the comment it works, so I'll approve it when the comment's fixed 👍

src/api/v1beta1/feature_flags_resources.go Outdated Show resolved Hide resolved
@0sewa0 0sewa0 requested a review from meik99 April 21, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to core functionality of the Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants