Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor component feature and version labels #726

Merged
merged 12 commits into from
Apr 20, 2022

Conversation

chrismuellner
Copy link
Collaborator

@chrismuellner chrismuellner commented Apr 14, 2022

Description

The components (activegate and oneagent) managed by the operator should have their version included in the labels.

Following labels/annotations were changed:

  • Set app.kubernetes.io/name to oneagent or activegate
  • Set app.kubernetes.io/version to oneagent or activegate version
  • Replaced component.dynatrace.com/feature with app.kubernetes.io/component for the oneagent mode or activegate capability
  • Removed version annotation on activegate/oneagent pods

How can this be tested?

Deploy a dynakube with any oneagent mode and any activegate capability enabled.

Expected labels after this change:

  • oneagent:
  labels:
    app.kubernetes.io/name: oneagent
    app.kubernetes.io/component: cloudnativefullstack
    app.kubernetes.io/version: 1.241.0.20220413-171953
    app.kubernetes.io/created-by: dynakube
    app.kubernetes.io/managed-by: dynatrace-operator
    
  selector:
    matchLabels:
      app.kubernetes.io/name: oneagent
      app.kubernetes.io/created-by: dynakube
      app.kubernetes.io/managedy-by: dynatrace-operator
      
  • activegate:
  labels:
    app.kubernetes.io/name: activegate
    app.kubernetes.io/component: activegate
    app.kubernetes.io/version: 1.241.0.20220414-004007
    app.kubernetes.io/created-by: dynakube
    app.kubernetes.io/managed-by: dynatrace-operator
    
  selector:
    matchLabels:
      app.kubernetes.io/name: activegate
      app.kubernetes.io/created-by: dynakube
      app.kubernetes.io/managedy-by: dynatrace-operator
      
  • other resources (e.g. secret) that are connected to oneagent/activegate but shouldn't change between versions
labels:
    app.kubernetes.io/component: activegate
    app.kubernetes.io/created-by: dynakube
    app.kubernetes.io/name: dynatrace-operator
    

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@chrismuellner chrismuellner added the core Changes to core functionality of the Operator label Apr 14, 2022
@chrismuellner chrismuellner requested a review from a team as a code owner April 14, 2022 11:37
src/kubeobjects/labels.go Outdated Show resolved Hide resolved
meik99
meik99 previously requested changes Apr 19, 2022
src/agproxysecret/secret.go Show resolved Hide resolved
src/kubeobjects/labels.go Show resolved Hide resolved
src/kubeobjects/labels.go Show resolved Hide resolved
src/kubeobjects/labels.go Outdated Show resolved Hide resolved
src/kubeobjects/labels.go Outdated Show resolved Hide resolved
src/kubeobjects/labels.go Outdated Show resolved Hide resolved
@chrismuellner chrismuellner enabled auto-merge (squash) April 20, 2022 14:11
@chrismuellner chrismuellner merged commit 7ecbe95 into release-0.6 Apr 20, 2022
@chrismuellner chrismuellner deleted the feature/version-label-components branch April 20, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to core functionality of the Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants