-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor component feature and version labels #726
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgrzybek
reviewed
Apr 15, 2022
0sewa0
reviewed
Apr 15, 2022
0sewa0
reviewed
Apr 15, 2022
meik99
previously requested changes
Apr 19, 2022
0sewa0
reviewed
Apr 19, 2022
0sewa0
reviewed
Apr 19, 2022
0sewa0
reviewed
Apr 19, 2022
0sewa0
reviewed
Apr 19, 2022
0sewa0
approved these changes
Apr 20, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The components (activegate and oneagent) managed by the operator should have their version included in the labels.
Following labels/annotations were changed:
app.kubernetes.io/name
tooneagent
oractivegate
app.kubernetes.io/version
to oneagent or activegate versioncomponent.dynatrace.com/feature
withapp.kubernetes.io/component
for the oneagent mode or activegate capabilityHow can this be tested?
Deploy a dynakube with any oneagent mode and any activegate capability enabled.
Expected labels after this change:
Checklist