-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements copying codeModules from image. #729
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0sewa0
added
oneagent
Changes related to Oneagent
and removed
core
Changes to core functionality of the Operator
labels
Apr 15, 2022
meik99
suggested changes
Apr 19, 2022
0sewa0
force-pushed
the
feature/copy-from-image
branch
from
April 21, 2022 10:44
aa0f396
to
72519b7
Compare
0sewa0
force-pushed
the
feature/copy-from-image
branch
from
April 26, 2022 11:51
365438b
to
42da16a
Compare
chrismuellner
requested changes
Apr 26, 2022
meik99
previously requested changes
Apr 27, 2022
chrismuellner
approved these changes
Apr 29, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change gets the image specified in the
codeModulesImage
field and unpacks it's contents into the right place using the csi-driver. The outcome is meant to be the same as getting the zip from the tenant, but this way the user can scan the contents of the image they want us to install.Some extra logic had to be added where the version is important (creating the symlink) as the image not necessarily has this information plainly available.
How can this be tested?
codeModulesImage
to that image./data/<tenant>/bin/<image-tag>
)Checklist