Add feature flag for ignoring proxy within oneAgent and activeGate #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meik99
previously requested changes
Apr 21, 2022
src/controllers/activegate/reconciler/statefulset/statefulset.go
Outdated
Show resolved
Hide resolved
0sewa0
approved these changes
Apr 26, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we have the problem, when a proxy is set in the custom resource, it will get applied to all the components (operator, oneAgent and activeGate). This is so far intended, but if there is an activeGate with the purpose of routing agents traffic, then the oneAgent will also try to connect to the activeGate using the proxy, which causes problems
How can this be tested?
Setup the operator and set a proxy in the customResource. This proxy will get applied to dtclient, oneAgents and activeGate (if defined in the same CR). If you add one or both featureFlags
proxy should not be set for activeGate and/or oneAgent
Checklist