Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version to ^1.18 #742

Merged
merged 6 commits into from
Apr 26, 2022
Merged

Bump go version to ^1.18 #742

merged 6 commits into from
Apr 26, 2022

Conversation

mjgrzybek
Copy link
Contributor

Description

Follow-up of #651

go version is set to 1.18.1.
Some problems with linters may occur when using generics. It should be addressed when working with generics.

How can this be tested?

  • build image
  • execute unit tests

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@mjgrzybek mjgrzybek added the core Changes to core functionality of the Operator label Apr 25, 2022
@mjgrzybek mjgrzybek requested a review from a team as a code owner April 25, 2022 09:19
@mjgrzybek mjgrzybek enabled auto-merge (squash) April 25, 2022 09:37
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Copy link
Collaborator

@chrismuellner chrismuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version is a bit inconsistent in CI and Dockerfile.

@mjgrzybek mjgrzybek force-pushed the feature/go1.18 branch 2 times, most recently from a790401 to a46fb6f Compare April 26, 2022 09:35
@mjgrzybek
Copy link
Contributor Author

mjgrzybek commented Apr 26, 2022

version is a bit inconsistent in CI and Dockerfile.

@chrismuellner It never was and will never be.
Container image (golang:1.18-alpine) and actions/setup-go@v2 are independent and versioning granularity may differ. I'd suggest to stick just to "^1.18".
Even if versions slightly differ in patch number, it shouldn't be an issue.

@mjgrzybek mjgrzybek changed the title Bump go version to 1.18.1 Bump go version to ^1.18 Apr 26, 2022
@mjgrzybek mjgrzybek merged commit 477ff1f into master Apr 26, 2022
@mjgrzybek mjgrzybek deleted the feature/go1.18 branch April 26, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to core functionality of the Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants