Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for empty high availability flag #747

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

mjgrzybek
Copy link
Contributor

Description

If helm is deployed with values.yaml with no webhook.highAvailability set, upgrade to release-0.6 fails.

$ helm upgrade dynatrace-operator config/helm/chart/default/ --reuse-values --atomic --namespace dynatrace -v3
Error: UPGRADE FAILED: template: dynatrace-operator/templates/Common/webhook/deployment-webhook.yaml:24:62: executing "dynatrace-operator/templates/Common/webhook/deployment-webhook.yaml" at <1>: invalid value; expected bool

How can this be tested?

  1. deploy release-0.5 - https://www.dynatrace.com/support/help/setup-and-configuration/setup-on-container-platforms/kubernetes/set-up-k8s-monitoring-with-helm
  2. helm upgrade dynatrace-operator config/helm/chart/default/ --reuse-values --atomic --namespace dynatrace

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@mjgrzybek mjgrzybek added bug Something isn't working helm Changes to helm templates or values file labels Apr 27, 2022
@mjgrzybek mjgrzybek requested a review from a team as a code owner April 27, 2022 11:03
@mjgrzybek mjgrzybek changed the title Bugfix/helm ha invalid value Helm fails upgrading 0.5 -> 0.6 Apr 27, 2022
@mjgrzybek mjgrzybek changed the base branch from master to release-0.6 April 27, 2022 11:04
@mjgrzybek mjgrzybek changed the title Helm fails upgrading 0.5 -> 0.6 Fix check for empty high availability flag Apr 27, 2022
@mjgrzybek mjgrzybek force-pushed the bugfix/helm-ha-invalid-value branch from 64ae196 to e5ae4ec Compare April 27, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working helm Changes to helm templates or values file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants