Updates csi garbage-collector logic to work with images #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgrzybek
reviewed
Apr 27, 2022
0sewa0
changed the title
meik99
suggested changes
Apr 29, 2022
0sewa0
force-pushed
the
feature/clean-image-cache
branch
from
687c753
to
8aca779
Compare
0sewa0
changed the title
meik99
reviewed
May 4, 2022
0sewa0
force-pushed
the
feature/clean-image-cache
branch
from
8aca779
to
924ef4e
Compare
meik99
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The image cache needs to be cleaned up otherwise the we can flood the node's filesystem with many 200MB+ image dirs.
This deletes any cached image that haven't been pulled for 2 weeks.
Every pull for an image changes its
index.jsoneven if the image was already cached, so its a good indicator of usage.How can this be tested?
Well this is kinda hard, as for the "thing" to happen you need to wait for 2 weeks.
What you can do is change the time locally to 10 mins or something,
build the operator and use it, then create a dynakube that has
codeModulesImageset.Checklist