Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip cache removal when file does not exist #754

Merged
merged 4 commits into from
Apr 29, 2022

Conversation

chrismuellner
Copy link
Collaborator

@chrismuellner chrismuellner commented Apr 28, 2022

Description

Install agent binaries when installed version is "" (empty), but the <tenant>/bin/<target version> directory exists. This means the previous attempt to install agent failed (e.g. OOM during unzip), only created the bin folder but did not update the database with the correct version.

How can this be tested?

Dynakube that needs CSI driver is deployed:

  1. CSI driver crashes during unzip (after creating bin folder with version)
  2. CSI driver restarts and tries to update ruxitagentproc.conf without an installed version

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@chrismuellner chrismuellner added the bug Something isn't working label Apr 28, 2022
@meik99 meik99 self-requested a review April 29, 2022 05:43
@chrismuellner chrismuellner marked this pull request as ready for review April 29, 2022 08:31
@chrismuellner chrismuellner requested a review from a team as a code owner April 29, 2022 08:31
Copy link
Contributor

@waodim waodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the points which @meik99 brought up, which are already resolved anyway, everything looks fine to me.

@chrismuellner chrismuellner merged commit 1a9a222 into release-0.6 Apr 29, 2022
@chrismuellner chrismuellner deleted the fix/provisioner-cache-removal branch April 29, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants