Replace the latest oneagent version endpoint to use the versions endpoint #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meik99
previously requested changes
May 2, 2022
chrismuellner
approved these changes
May 2, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The latest agent version endpoint we use can't be trusted to give us a version that we can actually download. (it provides the latest version for a different kind of installer).
So instead of that we use the get all versions endpoint and find the latest from that.
How can this be tested?
Deploy cloudnative on a cluster where
/deployment/installer/agent/unix/paas/latest/metainforeturns a version that is not present inthe output
/deployment/installer/agent/versions/unix/paasand it shouldn't error anymore.
Checklist