Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary ports in manifests #766

Merged
merged 7 commits into from
May 5, 2022
Merged

Remove unnecessary ports in manifests #766

merged 7 commits into from
May 5, 2022

Conversation

waodim
Copy link
Contributor

@waodim waodim commented May 5, 2022

Description

Removed unnecessary ports in the k8s manifest. The functionality of the webhook and the operator remains the same even without those ports.

How can this be tested?

Simply apply the manifest without those ports and watch the behavior.

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@waodim waodim added the core Changes to core functionality of the Operator label May 5, 2022
@waodim waodim requested a review from a team as a code owner May 5, 2022 07:41
@waodim waodim changed the title Remove unnecessary ports in kubernetes manifest Remove unnecessary ports in manifests May 5, 2022
@0sewa0
Copy link
Contributor

0sewa0 commented May 5, 2022

run make manifests so the openshift_all will also get updated

0sewa0
0sewa0 approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@0sewa0 0sewa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried it out, noticed no problems (validation and pod mutattion worked as expected)

@waodim waodim merged commit 447cbb0 into master May 5, 2022
@waodim waodim deleted the feature/remove-unnecessary-ports branch May 5, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0sewa0 0sewa0 0sewa0 approved these changes

Assignees
No one assigned
Labels
core Changes to core functionality of the Operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@waodim @0sewa0