Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes unintentional introduction of DEPLOYED_VIA_OLM environment variable #784

Merged
merged 1 commit into from
May 10, 2022
Merged

Fixes unintentional introduction of DEPLOYED_VIA_OLM environment variable #784

merged 1 commit into from
May 10, 2022

Conversation

meik99
Copy link
Contributor

@meik99 meik99 commented May 10, 2022

Description

Removes the ´DEPLOYED_VIA_OLM` environment variable from normal deployment manifests.

How can this be tested?

Both kubernetes-all.yaml and openshift-all.yaml should deploy the Operator and Webhook without the DEPLOYED_VIA_OLM environment variable.

Checklist

  • Unit tests have been updated/added
  • PR is labeled accordingly

@meik99 meik99 added the bug Something isn't working label May 10, 2022
@meik99 meik99 requested a review from a team as a code owner May 10, 2022 10:42
@meik99 meik99 merged commit 3c935fd into master May 10, 2022
@meik99 meik99 deleted the feature/fix-hack-move branch May 10, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrismuellner chrismuellner chrismuellner approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@meik99 @chrismuellner