Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reusable build-dockerimage and push-dockerimage workflows #788

Merged
merged 5 commits into from
May 25, 2022

Conversation

aorcholski
Copy link
Contributor

@aorcholski aorcholski commented May 19, 2022

'builddockerimage' workflow is responsible for building the operator for given platform. The outcome is operator-{platform}.zip artifact.
'uploaddockerimage' workflow uploads the artifact for given platform to the registry.
The main CI workflow builds and uploads images for amd64 and arm64 platforms (arm build is conditional) using reusable workflows and finally combines images creating docker manifest.

How can this be tested?

Reusable workflows were tested using forked repo and private account in quay.io registry.

Checklist

- [ ] Unit tests have been updated/added

  • PR is labeled accordingly

@aorcholski aorcholski added the ci Updates to the pipeline label May 19, 2022
@aorcholski aorcholski force-pushed the feature/build_push_actions branch 18 times, most recently from e483422 to 19dbb73 Compare May 20, 2022 10:43
@aorcholski aorcholski marked this pull request as ready for review May 20, 2022 10:54
@aorcholski aorcholski requested a review from a team as a code owner May 20, 2022 10:54
.github/workflows/builddockerimage.yml Outdated Show resolved Hide resolved
.github/workflows/builddockerimage.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/builddockerimage.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/uploaddockerimage.yml Outdated Show resolved Hide resolved
@aorcholski aorcholski force-pushed the feature/build_push_actions branch 8 times, most recently from 1b1d2d9 to e0652c4 Compare May 23, 2022 13:26
meik99
meik99 previously approved these changes May 25, 2022
Copy link
Contributor

@meik99 meik99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, as long as the actions run

@chrismuellner chrismuellner changed the title Reusable builddockerimage, pushdockerimage workflows added Add reusable build-dockerimage and push-dockerimage workflows May 25, 2022
@aorcholski aorcholski force-pushed the feature/build_push_actions branch 3 times, most recently from b9c09de to b8e932c Compare May 25, 2022 14:59
@aorcholski aorcholski merged commit 3a9721e into master May 25, 2022
@aorcholski aorcholski deleted the feature/build_push_actions branch May 25, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Updates to the pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants