-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reusable build-dockerimage
and push-dockerimage
workflows
#788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aorcholski
force-pushed
the
feature/build_push_actions
branch
18 times, most recently
from
May 20, 2022 10:43
e483422
to
19dbb73
Compare
chrismuellner
requested changes
May 20, 2022
aorcholski
force-pushed
the
feature/build_push_actions
branch
8 times, most recently
from
May 23, 2022 13:26
1b1d2d9
to
e0652c4
Compare
meik99
previously approved these changes
May 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, as long as the actions run
chrismuellner
requested changes
May 25, 2022
chrismuellner
changed the title
Reusable builddockerimage, pushdockerimage workflows added
Add reusable May 25, 2022
build-dockerimage
and push-dockerimage
workflows
aorcholski
force-pushed
the
feature/build_push_actions
branch
3 times, most recently
from
May 25, 2022 14:59
b9c09de
to
b8e932c
Compare
chrismuellner
approved these changes
May 25, 2022
…bled (uploadarm64) action
aorcholski
force-pushed
the
feature/build_push_actions
branch
from
May 25, 2022 15:09
b8e932c
to
e40667b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'builddockerimage' workflow is responsible for building the operator for given platform. The outcome is operator-{platform}.zip artifact.
'uploaddockerimage' workflow uploads the artifact for given platform to the registry.
The main CI workflow builds and uploads images for amd64 and arm64 platforms (arm build is conditional) using reusable workflows and finally combines images creating docker manifest.
How can this be tested?
Reusable workflows were tested using forked repo and private account in quay.io registry.
Checklist
- [ ] Unit tests have been updated/added