Add feature flag for setting DT_INITIAL_CONNECT_RETRY_MS env-var to webhook injected containers
#790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luhi-DT
changed the title
luhi-DT
changed the title
luhi-DT
changed the title
DT_INITIAL_CONNECT_RETRY_MS env-var to webhook injected containers
waodim
previously approved these changes
May 20, 2022
mjgrzybek
suggested changes
May 20, 2022
mjgrzybek
reviewed
May 20, 2022
mjgrzybek
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to support istio, we need to give customer the possibility to set
DT_INITIAL_CONNECT_RETRY_MSvia the webhook to their containers, in order to delay the startup of the agent. It was decided that it should be a feature flag, rather than tightly coupling it with theenableIstiofield in the CR. Therefore I introduced thefeature.dynatrace.com/oneagent-initial-connect-retry-msfeature flag, where customers can set the preferred value.How can this be tested?
Create a Dynakube (either with applicationMonitoring or cloudNative) and add the annotation
feature.dynatrace.com/oneagent-initial-connect-retry-ms: "<value>"to it. Any pod which is injected now should get the env varDT_INITIAL_CONNECT_RETRY_MSset to its containers, with the according value.Checklist